ROX-14696: Add terraforming and probe deployment to acs-stage-eu-01.

[ebensh]

Description

Adds acs-stage-eu-01 terraforming to the CD pipeline.

https://issues.redhat.com/browse/ROX-14696

Checklist (Definition of Done)

• Unit and integration tests added
• Added test description under Test manual
• Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
• CI and all relevant tests are passing
• Add the ticket number to the PR title if available, i.e. ROX-12345: ...
• Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

I could manually CD the cluster but I want to ensure adding it to CD is a supported way to do the initial bootstrapping. Per https://github.com/stackrox/acs-fleet-manager/blob/main/.github/workflows/deploy-stage.yaml#L5-L8 that means we need to merge to main and fix it if it's broken.

[ebensh]

Current dependencies on/for this PR:

• main
  • PR ROX-14696: Add terraforming and probe deployment to acs-stage-eu-01. #848 👈

This comment was auto-generated by Graphite.

[porridge]

Perhaps it's possible to move this up a level to prevent repetition? 🤔

[ebensh]

I thought about it - my concern was then that if a single cluster terraform fails, all of them would fail. We want to have set -euo pipefail so that, if I understand it correctly, individual commands inside the terraform script failing would cause an overall failure; but we don't want the overall command to fail if any individual terraform failed.

What are your thoughts?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, porridge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ebensh,porridge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ebensh]

I'm concerned about a higher level problem regarding admin password creation that I will address separately in Slack. This can still be reviewed, but I won't merge until that discussion is done too.

[ebensh]

I thought about it - my concern was then that if a single cluster terraform fails, all of them would fail. We want to have set -euo pipefail so that, if I understand it correctly, individual commands inside the terraform script failing would cause an overall failure; but we don't want the overall command to fail if any individual terraform failed.

What are your thoughts?

[porridge]

I thought about it - my concern was then that if a single cluster terraform fails, all of them would fail.

I think we're talking about different things.
I'm just thinking about moving the env block to the parent so that we don't need the same block in 3 places.

[ebensh]

/retest-required

[ebensh]

/retest

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[stehessel]

Maybe use https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs?

[porridge]

We probably want to run these in sequence and stop after first failure. Not sure if this is possible with matrix.

[ebensh]

I'm just thinking about moving the env block to the parent so that we don't need the same block in 3 places.

I've made the change, but it looks less explicit and more magical to me having the env at the top.