Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-13913: change RDS CA certificate type #820

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

vladbologa
Copy link
Contributor

@vladbologa vladbologa commented Feb 13, 2023

Description

This PR changes the CA certificate type of provisioned RDS DBs.

  • Previously: certificate authority with RSA 2048 private key algorithm and SHA256 signing algorithm, expires in 2024 and doesn't support automatic server certificate rotation
  • Switch to: ECC 384 private key algorithm and SHA384 signing algorithm, supports automatic server certificate rotation

Checklist (Definition of Done)

- [ ] Unit and integration tests added

  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

CI is sufficient.

@vladbologa vladbologa temporarily deployed to development February 13, 2023 16:14 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimonBaeumer, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,vladbologa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vladbologa vladbologa merged commit 7e8cf2b into main Feb 13, 2023
@vladbologa vladbologa deleted the vbologa/ROX-13913-rds-certs branch February 13, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants