Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator install script #806

Merged
merged 6 commits into from
Feb 15, 2023
Merged

Conversation

SimonBaeumer
Copy link
Member

Description

Add operator install script to install and upgrade the operator independently of the setup scripts.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

  • run scripts

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@SimonBaeumer SimonBaeumer temporarily deployed to development February 10, 2023 13:11 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development February 10, 2023 13:12 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer requested a review from kovayur February 10, 2023 13:18
@SimonBaeumer SimonBaeumer temporarily deployed to development February 10, 2023 13:18 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer marked this pull request as ready for review February 10, 2023 13:18
@SimonBaeumer SimonBaeumer temporarily deployed to development February 10, 2023 13:18 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development February 10, 2023 13:19 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot added the lgtm label Feb 10, 2023
@SimonBaeumer SimonBaeumer enabled auto-merge (squash) February 10, 2023 13:24

wait_for_container_to_become_ready "$STACKROX_OPERATOR_NAMESPACE" "app=rhacs-operator" "manager" 900
fi
./install_operator.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls call using the full path, it will not work when I call the bootstrap script from the root folder for example (or using make)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other scripts are called locally too and it works. Removed the ./ though and call it like apply.

Copy link
Contributor

@kovayur kovayur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openshift-ci openshift-ci bot added the lgtm label Feb 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, SimonBaeumer, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,kovayur,vladbologa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SimonBaeumer SimonBaeumer merged commit c1f1bb8 into main Feb 15, 2023
@SimonBaeumer SimonBaeumer deleted the sb/add-operator-install-script branch February 15, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants