Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to AuthConfig fields. #766

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

ivan-degtiarenko
Copy link
Contributor

Description

Part of the effort to improve documentation of Central Request started by @SimonBaeumer here:
#743

Checklist (Definition of Done)

-~~ [ ] Unit and integration tests added~~
- [ ] Added test description under Test manual
- [ ] Evaluated and added CHANGELOG.md entry if required

  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
    - [ ] Add the ticket number to the PR title if available, i.e. ROX-12345: ...
    - [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

CI is enough

@ivan-degtiarenko ivan-degtiarenko temporarily deployed to development January 26, 2023 12:09 — with GitHub Actions Inactive
Copy link
Member

@rukletsov rukletsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks, Ivan!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan-degtiarenko, rukletsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivan-degtiarenko ivan-degtiarenko merged commit 40159e1 into main Jan 27, 2023
@ivan-degtiarenko ivan-degtiarenko deleted the ivan/add-central-request-auth-config-doc branch January 27, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants