ROX-14528: Add OCM mock client #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
stehessel
force-pushed
the
ROX-14528/ocm-mock
branch
from
3eb3d43 to
e93ef82
Compare
stehessel
force-pushed
the
ROX-14528/ocm-mock
branch
from
e93ef82 to
f1a4657
Compare
stehessel
had a problem deploying
to
development
GitHub Actions
Failure
vladbologa
approved these changes
Jan 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SimonBaeumer, stehessel, vladbologa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build a mocked OCM client if
ocmConfig.MockEnable=true. Change to the mocked OCM client as default for the development environment. The purpose of this change is enabling development without needing access to a real OCM service account.It seems some of the integration tests currently rely on the default being
OCM_ENV=development, which up to now setocmConfig.MockEnable=false. To compensate, integration tests now explicitly disable the OCM mock.The mocked OCM client returns a stubbed organisation upon request. It does not handle quota related endpoints, so it does not yet work in combination with
--quota-type=ams. For this, more OCM endpoints would need to be stubbed in the mocked client.Supersedes #758
Checklist (Definition of Done)
Test manualDocumentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Test manual
Verified that local execution without ocm service account credentials works.