-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-12344: Add org-id label and org-name annotation #684
Conversation
Skipping CI for Draft Pull Request. |
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
15762f3
to
d020373
Compare
394c0b7
to
156569a
Compare
/test all |
@stehessel: No presubmit jobs available for stackrox/acs-fleet-manager@ROX-12344/org-labels In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
156569a
to
225cc56
Compare
d020373
to
0f31385
Compare
225cc56
to
042e263
Compare
/ok-to-test |
/test all |
@stehessel: No presubmit jobs available for stackrox/acs-fleet-manager@ROX-12344/org-labels In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0f31385
to
8aa6009
Compare
042e263
to
5b7a29b
Compare
8aa6009
to
228dc55
Compare
5b7a29b
to
d2257b7
Compare
f7664d0
to
48737f5
Compare
d2257b7
to
6add689
Compare
48737f5
to
f27847c
Compare
6add689
to
2b8955c
Compare
f27847c
to
57ff9f3
Compare
2b8955c
to
2b4bb48
Compare
57ff9f3
to
d49b755
Compare
2b4bb48
to
80e60ed
Compare
d49b755
to
09658d9
Compare
80e60ed
to
5478456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
New changes are detected. LGTM label has been removed. |
0abc562
to
27db7d2
Compare
6a4a31d
to
4cc406e
Compare
4cc406e
to
a963444
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtodor, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add organisation meta data to the central tenant. The org name is set as an annotation, because it does not comply with Kubernetes validation rules.
We will scrape the label and annotations via Prometheus and pass them via metric labels to Grafana dashboards. This will be added as a follow up.
Checklist (Definition of Done)
Test manual
Evaluated and added CHANGELOG.md entry if requiredDocumentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Test manual
Tested with local fleet-manager and dev data-plane cluster.