Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backoff addon upgrade on a per install basis #2112

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

johannes94
Copy link
Contributor

@johannes94 johannes94 commented Dec 3, 2024

Description

The addon upgrade backoff was implemented without differencing upgrade requests to distinct clusters. So that any stuck upgrade would stop sending requests to clusters that are not stuck.

The Last Install status is now tracked on a per cluster and addon id basis. And the backoff logic respects that as well.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

CI

Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johannes94
Copy link
Contributor Author

/retest

@johannes94 johannes94 merged commit c4b135c into main Dec 4, 2024
15 checks passed
@johannes94 johannes94 deleted the jmalsam/addon-backoff-per-cluster branch December 4, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants