Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional argoCD parameters for Central CRs #2091

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

ludydoo
Copy link
Collaborator

@ludydoo ludydoo commented Nov 14, 2024

Description

Adding required argoCD application parameters in preparation of moving Central CRs to ArgoCD

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

"telemetryStorageKey": r.telemetry.StorageKey,
"telemetryStorageEndpoint": r.telemetry.StorageEndpoint,
"centralAdminPasswordEnabled": !r.wantsAuthProvider,
"centralDbSecretName": centralDbSecretName,
"tenant": map[string]interface{}{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be removing the tenant parameter in favor of a flatter parameter structure. (e.g. prefer organizationName to tenant.organizationName)

if err != nil {
return nil, fmt.Errorf("getting Central DB connection string: %w", err)
}
values["centralDbConnectionString"] = centralDBConnectionString
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving additionalCAs logic here?

Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ludydoo
Copy link
Collaborator Author

ludydoo commented Nov 14, 2024

/retest

@openshift-ci openshift-ci bot removed the lgtm label Nov 14, 2024
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

New changes are detected. LGTM label has been removed.

@ludydoo ludydoo merged commit ae69159 into main Nov 15, 2024
6 checks passed
@ludydoo ludydoo deleted the ROX-24524-add-additional-argocd-parameters branch November 15, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants