-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional argoCD parameters for Central CRs #2091
Conversation
"telemetryStorageKey": r.telemetry.StorageKey, | ||
"telemetryStorageEndpoint": r.telemetry.StorageEndpoint, | ||
"centralAdminPasswordEnabled": !r.wantsAuthProvider, | ||
"centralDbSecretName": centralDbSecretName, | ||
"tenant": map[string]interface{}{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will be removing the tenant
parameter in favor of a flatter parameter structure. (e.g. prefer organizationName
to tenant.organizationName
)
if err != nil { | ||
return nil, fmt.Errorf("getting Central DB connection string: %w", err) | ||
} | ||
values["centralDbConnectionString"] = centralDBConnectionString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving additionalCAs logic here?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
New changes are detected. LGTM label has been removed. |
Description
Adding required argoCD application parameters in preparation of moving Central CRs to ArgoCD
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TODO: Add manual testing efforts