Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lc/ROX-26523-dev-argocd #2074

Merged
merged 1 commit into from
Oct 23, 2024
Merged

lc/ROX-26523-dev-argocd #2074

merged 1 commit into from
Oct 23, 2024

Conversation

ludydoo
Copy link
Collaborator

@ludydoo ludydoo commented Oct 16, 2024

Description

This PR changes the local dev bootstrap script to install ArgoCD (for non-openshift clusters) or Openshift-Gitops (for openshift clusters)

There is a functional difference between "vanilla" ArgoCD vs Openshift Gitops

  • ArgoCD deploys in the argocd namespace
  • Openshift GitOps deploys in the openshift-gitops namespace
  • Namespaces that allow ArgoCD/OpenshiftGitops must be labeled with argocd.argoproj.io/managed-by: <namespace_where_argocd_is_installed>
  • This label will be added in an upcoming PR

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing~~
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment
# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@ludydoo ludydoo changed the base branch from main to ROX-26039-create-argocd-tenant-app October 16, 2024 12:03
@ludydoo ludydoo force-pushed the lc/ROX-26523-dev-argocd branch from 31860c6 to 6799d76 Compare October 22, 2024 07:59
@ludydoo ludydoo changed the base branch from ROX-26039-create-argocd-tenant-app to main October 22, 2024 08:01
@ludydoo ludydoo requested a review from johannes94 October 22, 2024 08:04
@ludydoo ludydoo force-pushed the lc/ROX-26523-dev-argocd branch from d4c8194 to 7a0188c Compare October 22, 2024 08:05
@ludydoo ludydoo force-pushed the lc/ROX-26523-dev-argocd branch from 3a9ab6c to d812c22 Compare October 22, 2024 08:13
@ludydoo ludydoo requested a review from kovayur October 22, 2024 08:14
@ludydoo
Copy link
Collaborator Author

ludydoo commented Oct 22, 2024

/retest

@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2024
Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ludydoo ludydoo merged commit cd84fd4 into main Oct 23, 2024
15 checks passed
@ludydoo ludydoo deleted the lc/ROX-26523-dev-argocd branch October 23, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants