-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lc/ROX-26523-dev-argocd #2074
Merged
Merged
lc/ROX-26523-dev-argocd #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludydoo
changed the base branch from
main
to
ROX-26039-create-argocd-tenant-app
October 16, 2024 12:03
ludydoo
force-pushed
the
lc/ROX-26523-dev-argocd
branch
from
October 22, 2024 07:59
31860c6
to
6799d76
Compare
ludydoo
changed the base branch from
ROX-26039-create-argocd-tenant-app
to
main
October 22, 2024 08:01
ludydoo
force-pushed
the
lc/ROX-26523-dev-argocd
branch
from
October 22, 2024 08:05
d4c8194
to
7a0188c
Compare
ludydoo
force-pushed
the
lc/ROX-26523-dev-argocd
branch
from
October 22, 2024 08:13
3a9ab6c
to
d812c22
Compare
/retest |
johannes94
approved these changes
Oct 23, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the local dev bootstrap script to install ArgoCD (for non-openshift clusters) or Openshift-Gitops (for openshift clusters)
There is a functional difference between "vanilla" ArgoCD vs Openshift Gitops
argocd
namespaceopenshift-gitops
namespaceargocd.argoproj.io/managed-by: <namespace_where_argocd_is_installed>
Checklist (Definition of Done)
Unit and integration tests addedAdded test description underTest manual
Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Add secret to app-interface Vault or Secrets Manager if necessaryRDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resources(If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment