ROX-21530: Updating Cert Expiry Metrics #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaa5kameric
temporarily deployed
to
development
GitHub Actions
Inactive
10 tasks
aaa5kameric
temporarily deployed
to
development
GitHub Actions
Inactive
aaa5kameric
temporarily deployed
to
development
GitHub Actions
Inactive
|
/retest |
1 similar comment
|
/retest |
ludydoo
reviewed
Oct 9, 2024
|
You need to rebase to fix CI pre commit |
aaa5kameric
temporarily deployed
to
development
GitHub Actions
Inactive
aaa5kameric
temporarily deployed
to
development
GitHub Actions
Inactive
aaa5kameric
temporarily deployed
to
development
GitHub Actions
Inactive
ludydoo
reviewed
Oct 15, 2024
ludydoo
reviewed
Oct 15, 2024
aaa5kameric
temporarily deployed
to
development
GitHub Actions
Inactive
ludydoo
approved these changes
Oct 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaa5kameric, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Background: Implement monitoring for certificate expiration, tracking and managing of digital certificates expiration dates. Extracts timestamps from certificates and exposes metrics to Prometheus. (FIXED)
In response to error in: stackrox/rhacs-observability-resources#279
Problem:
acs_fleetshard_certificate_expiration_timestamp- seems to retain all certificates even after their namespaces have been deleted. Combined with the ephemeral instances created by the probe, this creates a very large number of time series.Solution: Fixed the handling of metric deletion by:
-adding namespace informer
-implemented
DeletePartialMatchinstead ofDeletePrevious Certificate Monitoring PR: #1946
Previous Certificate Alerting PR: stackrox/rhacs-observability-resources#276
Tests
Created k9s environment locally with pods/namespaces. Used
create-central.shanddelete-central.shscripts to test local host metric creation and deletion.