Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-26535: Combine konflux bot pre-commit PRs #2061

Merged
merged 11 commits into from
Oct 11, 2024

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented Oct 7, 2024

Description

Konflux bot opened pre-commit bumping deps PRs:

Some of those PRs needs manual changes to fix CI so this PR provides it

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

make pre-commit

red-hat-konflux bot and others added 8 commits September 17, 2024 12:04
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
….6.0

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…ct-secrets-1.x' into akurlov/ROX-26535-combine-konflux-bot-chores-prs
…t-pre-commit-hooks-4.x' into akurlov/ROX-26535-combine-konflux-bot-chores-prs
…golangci-lint-1.x' into akurlov/ROX-26535-combine-konflux-bot-chores-prs
@kurlov kurlov changed the title ROX-26535: Combine konflux bot chores prs ROX-26535: Combine konflux bot pre-commit PRs Oct 7, 2024
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov kurlov merged commit 31acf05 into main Oct 11, 2024
12 checks passed
@kurlov kurlov deleted the akurlov/ROX-26535-combine-konflux-bot-chores-prs branch October 11, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants