Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-26424: Add service account with quay secret to ACSCS probe service #2050

Merged

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented Sep 27, 2024

Description

Add serviceAccount with quay secret to ACSCS probe service. It should fix lack of permission to pull images from Konflux quay org on app-interface for the service

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

N/A

@kurlov kurlov requested a review from kovayur September 27, 2024 12:29
@kurlov
Copy link
Member Author

kurlov commented Sep 27, 2024

/override ci/prow/e2e

Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

@kurlov: Overrode contexts on behalf of kurlov: ci/prow/e2e

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov kurlov merged commit 3d2307c into main Sep 27, 2024
8 checks passed
@kurlov kurlov deleted the akurlov/ROX-26424-add-serviceaccount-to-probe-with-quay-secret branch September 27, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants