Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default for make test/integration #2049

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

johannes94
Copy link
Contributor

@johannes94 johannes94 commented Sep 26, 2024

Description

By default make test/integration does not set any OCM_ENV environment variable. Because of that local executions usually fails with 5 failing tests while CI execution succeeds because it sets OCM_ENV=integration in the workflow definition.

Since those tests are integration tests and expect to have OCM_ENV=integration set to succeed this env variable should be set by default for the Makefile target.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make test/integration

@johannes94 johannes94 requested a review from kovayur September 26, 2024 12:05
@johannes94 johannes94 removed the request for review from kovayur September 26, 2024 12:07
Copy link
Collaborator

@GrimmiMeloni GrimmiMeloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, GrimmiMeloni, johannes94, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ebensh,johannes94,kurlov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johannes94
Copy link
Contributor Author

/retest

@johannes94 johannes94 merged commit a073ad8 into main Sep 27, 2024
12 checks passed
@johannes94 johannes94 deleted the jmalsam/fix-default-make-test-integration branch September 27, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants