-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-26360: OCM AuthType Deleted and Replaced #2047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not merge before #2048 otherwise it will break the probe service
ocmRefreshToken := os.Getenv(ocmRefreshTokenEnvVar) | ||
if ocmRefreshToken == "" { | ||
panic(fmt.Sprintf("%s not set. Please set OCM token with 'export %s=$(ocm token --refresh)'", ocmRefreshTokenEnvVar, ocmRefreshTokenEnvVar)) | ||
func AuthenticatedClientWithStaticToken(ctx context.Context) *fleetmanager.Client { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to remove AuthenticatedClientWithRHOASToken
function and use AuthenticatedClientWithStaticToken
, they serve the same purpose
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaa5kameric, kovayur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
OCM AuthType and related configuration deleted from Fleet Manager Client
AuthenticatedClientWithOCM
---> replaced withAuthenticatedClientWithStaticToken
.And related E2E tests for OCM Authentication Deleted
https://issues.redhat.com/projects/ROX/issues/ROX-26360?filter=myopenissues
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TODO: Add manual testing efforts