Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stackrox/rox dep from 4.4.2 to 4.5.1 #2010

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

ebensh
Copy link
Collaborator

@ebensh ebensh commented Sep 4, 2024

Description

Necessary for rolling out disabling network policies and removing gitops overrides.

Slack context: https://redhat-internal.slack.com/archives/C073ZQQN6HE/p1725374420422179

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, ludydoo, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ebensh,ludydoo,vladbologa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebensh ebensh force-pushed the ebenshet/bump-stackrox-dep-to-4.5.1 branch from 2dde0a0 to 0f1466b Compare September 4, 2024 11:23
@openshift-ci openshift-ci bot removed the lgtm label Sep 4, 2024
Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

New changes are detected. LGTM label has been removed.

@ebensh ebensh merged commit 979c542 into main Sep 4, 2024
6 checks passed
@ebensh ebensh deleted the ebenshet/bump-stackrox-dep-to-4.5.1 branch September 4, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants