Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-26038: add per-tenant argoCd flag #2008

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

ludydoo
Copy link
Collaborator

@ludydoo ludydoo commented Sep 2, 2024

Description

Adding a flag to enable or disable the use of ArgoCD per-tenant

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@openshift-ci openshift-ci bot added the approved label Sep 2, 2024
Base automatically changed from ROX-26027-argocd-namespace-labels to main September 4, 2024 12:05
@ludydoo ludydoo force-pushed the ROX-26038-argocd-tenant-flag branch from cb7795a to 2f08d57 Compare September 4, 2024 12:10
@ludydoo ludydoo requested a review from kovayur October 14, 2024 09:33
Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ludydoo ludydoo merged commit 543fe10 into main Oct 14, 2024
6 checks passed
@ludydoo ludydoo deleted the ROX-26038-argocd-tenant-flag branch October 14, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants