-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-25847: add argocd types #1991
Conversation
argocd/v1alpha1/README.md
Outdated
@@ -0,0 +1,4 @@ | |||
These types were copy-pasted from https://github.com/argoproj/argo-cd/tree/master/pkg/apis/application/v1alpha1 | |||
|
|||
We are not importing the ArgoCD dependency itself, because it would significantly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to add it as a Go dependency first and decided along the way that it wasn't worth the effort because of actual complexity in go.mod and conflicts with stackrox or is this a hypothesis that might never become true?
Asking because I'd honestly rather have a more complex go.mod as opposed to having to maintain this kind of implicit dependency over the lifetime of this product and possibly a lot of different ArgoCD versions in the long run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially tried that, and got some errors. But I suspect a brain fart on my part. It's working well now by importing the repo directly, after updating the go.mod
toolchain
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
/retest |
2 similar comments
/retest |
/retest |
Description
Checklist (Definition of Done)
Unit and integration tests addedAdded test description underTest manual
Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Add secret to app-interface Vault or Secrets Manager if necessaryRDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resources(If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environmentTest manual
TODO: Add manual testing efforts