Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ACS Operator base image #1961

Closed

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented Jul 25, 2024

Description

This also should resolve a few fixable vulnerabilities on ACS Dogfooding instance.
There was an issue to upgrade to 1.34 in the past #1687
The 1.34 issue might resolved. We can try migrating to 1.35

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

It does not cover full acs fleetshard operator flow

cd dp-terraform/helm
podman build -t test-35-sdk .
podman run --rm -it --entrypoint /bin/sh test-35-sdk

Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kurlov kurlov requested a review from kovayur July 26, 2024 13:00
@kurlov kurlov marked this pull request as ready for review July 26, 2024 13:00
Copy link
Contributor

openshift-ci bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov
Copy link
Member Author

kurlov commented Jul 26, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Jul 26, 2024

@kurlov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 308c01e link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kurlov
Copy link
Member Author

kurlov commented Jul 26, 2024

E2E tests show that the issue still persists in 1.35. Even though ACS Fleetshard operators listens to the correct resource in the correct namespace it does not create the FS instance
I close PR for now

@kurlov kurlov closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants