Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-22354: autorotate DP secrets if data has changed #1933

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

johannes94
Copy link
Contributor

@johannes94 johannes94 commented Jul 2, 2024

Description

This PR changes the dataplane secret backup solution so that changes in secret data on a data plane cluster will automatically also updated the encrypted secret backup for quick recovery stored in FM's DB.

With this change the backup in FM will store changed secrets, even if they've been compromised and are invalid. This is ok, since the goal of this backup is quick recovery in case of accidental deletion or cluster failure. In case of compromised/invalid secrets for any reason we can use the S3 velero backups done by OSD.

Runbook Change:
https://gitlab.cee.redhat.com/stackrox/acs-cloud-service/runbooks/-/merge_requests/112

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

e2e tests in CI tests that backup / restore of secrets is still working like expected
Added additional unit testing to make sure equality logic for sums is correct.

@johannes94 johannes94 force-pushed the jmalsam/autorotate-dataplane-secret branch from d47303e to 72d13b9 Compare July 3, 2024 08:21
@johannes94 johannes94 force-pushed the jmalsam/autorotate-dataplane-secret branch from 9098362 to b547709 Compare July 3, 2024 08:38
@johannes94
Copy link
Contributor Author

/retest

@johannes94 johannes94 requested a review from a team July 5, 2024 07:45
@johannes94 johannes94 requested a review from ludydoo July 5, 2024 08:46
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johannes94 johannes94 merged commit db7e4e0 into main Jul 8, 2024
6 checks passed
@johannes94 johannes94 deleted the jmalsam/autorotate-dataplane-secret branch July 8, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants