Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-23260: Setup rate limiter #1904

Merged
merged 1 commit into from
Jun 21, 2024
Merged

ROX-23260: Setup rate limiter #1904

merged 1 commit into from
Jun 21, 2024

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented Jun 21, 2024 •
edited
Loading

Description

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

@kurlov kurlov requested review from ludydoo and kovayur June 21, 2024 16:49
@openshift-ci openshift-ci bot added the lgtm label Jun 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov kurlov merged commit 7a15d55 into main Jun 21, 2024
6 checks passed
@kurlov kurlov deleted the akurlov/ROX-23260-setup-rate-limiter branch June 21, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kovayur kovayur kovayur approved these changes

@ludydoo ludydoo Awaiting requested review from ludydoo

Assignees

@kovayur kovayur

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurlov @kovayur