ROX-11558: Run fleetshard-operator on dev/CI environments #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovayur
changed the title
kovayur
force-pushed
the
yury/ROX-11558-fleetshard-operator-ci
branch
from
d877291 to
b09f880
Compare
kovayur
force-pushed
the
yury/ROX-11558-fleetshard-operator-ci
branch
from
42fdfec to
55c5ada
Compare
kovayur
force-pushed
the
yury/ROX-11558-fleetshard-operator-ci
branch
from
55c5ada to
77153b0
Compare
kovayur
force-pushed
the
yury/ROX-11558-fleetshard-operator-ci
branch
from
77153b0 to
9248775
Compare
kovayur
force-pushed
the
yury/ROX-11558-fleetshard-operator-ci
branch
from
9248775 to
825730b
Compare
kovayur
changed the title
kovayur
commented
Jun 26, 2024
| @@ -57,10 +57,6 @@ var _ = Describe("Central", Ordered, func() { | |||
| var notes []string | |||
| var ctx = context.Background() | |||
|
|
|||
| BeforeEach(func() { | |||
There was a problem hiding this comment.
This negates the "should install ForceReconcile via gitops" step.
kovayur
commented
Jun 26, 2024
| @@ -49,13 +49,6 @@ else | |||
| log "Skipping installation of Vertical Pod Autoscaler" | |||
| fi | |||
|
|
|||
| if [[ "$INSTALL_VERTICAL_POD_AUTOSCALER_OLM" == "true" ]]; then | |||
There was a problem hiding this comment.
Superseded by the helm chart
kovayur
commented
Jun 26, 2024
| @@ -365,7 +365,7 @@ var _ = Describe("Central", Ordered, func() { | |||
| Should(BeEmpty(), "Started at %s", time.Now()) | |||
| }) | |||
|
|
|||
| It("should restore the default gitops config", func() { | |||
| AfterAll(func() { | |||
There was a problem hiding this comment.
Execute even if tests failed
kurlov
approved these changes
Jun 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I didn't have an opportunity to run locally on my machine. But looks great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run fleetshard-operator on dev/CI environments
Checklist (Definition of Done)
Test manualROX-12345: ...Test manual
E2E tests