Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24553: Possibility to add additional VPA recommenders #1888

Merged
merged 33 commits into from
Jul 5, 2024

Conversation

ludydoo
Copy link
Collaborator

@ludydoo ludydoo commented Jun 13, 2024

Description

  • Added a rhacs-vertical-pod-autoscaling helm chart to deploy additional VPA recommenders
  • Added a generic, reusable helm chart reconciler, because this included yet again another helm chart installation
  • Added a verticalPodAutoscaling field to the gitops config, as well as all the configuration options
  • Added a vpaReconciler that simply uses the generic helm reconciler above

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ludydoo
Copy link
Collaborator Author

ludydoo commented Jun 14, 2024

/retest

@openshift-ci openshift-ci bot removed the lgtm label Jun 18, 2024
Copy link
Contributor

openshift-ci bot commented Jun 18, 2024

New changes are detected. LGTM label has been removed.

@ludydoo ludydoo force-pushed the ROX-24553-additional-vpa-recommenders branch from 1252a0f to 63ea2e3 Compare July 1, 2024 11:31
@ludydoo ludydoo merged commit d5b920f into main Jul 5, 2024
6 checks passed
@ludydoo ludydoo deleted the ROX-24553-additional-vpa-recommenders branch July 5, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants