-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-24553: Possibility to add additional VPA recommenders #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovayur
approved these changes
Jun 13, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
New changes are detected. LGTM label has been removed. |
ludydoo
force-pushed
the
ROX-24553-additional-vpa-recommenders
branch
from
June 24, 2024 06:33
1952d57
to
d5ed26a
Compare
ludydoo
force-pushed
the
ROX-24553-additional-vpa-recommenders
branch
from
July 1, 2024 11:31
1252a0f
to
63ea2e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rhacs-vertical-pod-autoscaling
helm chart to deploy additional VPA recommendershelm chart reconciler
, because this included yet again another helm chart installationverticalPodAutoscaling
field to the gitops config, as well as all the configuration optionsvpaReconciler
that simply uses the generic helm reconciler aboveChecklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TODO: Add manual testing efforts