Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-22549: Change cluster_id label to cluster_name for the addon status metric #1872

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Jun 10, 2024

Description

For better readability

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur kovayur changed the title ROX-22549: Change cluster_id label to cluster_name ROX-22549: Change cluster_id label to cluster_name for the addon status metric Jun 10, 2024
@kovayur kovayur force-pushed the yury/ROX-22549-change-cluster-id-to-name branch from d6c5e59 to 8719423 Compare June 10, 2024 11:43
@kovayur kovayur force-pushed the yury/ROX-22549-change-cluster-id-to-name branch from 8719423 to bc49b67 Compare June 10, 2024 11:58
@kovayur kovayur force-pushed the yury/ROX-22549-change-cluster-id-to-name branch from bc49b67 to d3a8f0e Compare June 10, 2024 12:32
Copy link
Collaborator

@ebensh ebensh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; will this work without updating the saas.yaml / Vault secrets configuration for FM?

Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit 70bba1d into main Jun 10, 2024
6 checks passed
@kovayur kovayur deleted the yury/ROX-22549-change-cluster-id-to-name branch June 10, 2024 15:22
@kovayur
Copy link
Contributor Author

kovayur commented Jun 10, 2024

LGTM; will this work without updating the saas.yaml / Vault secrets configuration for FM?

I already changed the configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants