Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-23260: Add Rate Limiter Service #1867

Merged
merged 13 commits into from
Jun 12, 2024

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented Jun 6, 2024

Description

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kurlov kurlov requested a review from johannes94 June 6, 2024 07:56
emailsender/config/config.go Outdated Show resolved Hide resolved
emailsender/config/config.go Outdated Show resolved Hide resolved
emailsender/config/config.go Outdated Show resolved Hide resolved
@kurlov
Copy link
Member Author

kurlov commented Jun 10, 2024

/retest

@kurlov kurlov requested a review from johannes94 June 10, 2024 13:54
emailsender/pkg/db/connect.go Outdated Show resolved Hide resolved
emailsender/config/config.go Outdated Show resolved Hide resolved
emailsender/config/config.go Outdated Show resolved Hide resolved
emailsender/pkg/db/connect.go Show resolved Hide resolved
emailsender/pkg/db/connect.go Show resolved Hide resolved
emailsender/pkg/email/ratelimiter.go Outdated Show resolved Hide resolved
emailsender/pkg/email/ratelimiter.go Outdated Show resolved Hide resolved
@kurlov kurlov requested a review from johannes94 June 11, 2024 23:22
@kurlov
Copy link
Member Author

kurlov commented Jun 12, 2024

/retest

1 similar comment
@kurlov
Copy link
Member Author

kurlov commented Jun 12, 2024

/retest

Copy link
Contributor

@johannes94 johannes94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work :) Only a minor comment.

ctx := context.Background()

// initialize components
sesClient, err := email.NewSES(ctx)
dbConnection := db.NewDatabaseConnection(dbCfg)
_ = email.NewRateLimiterService(dbConnection)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this isn't used since you want to integrate this into emailhander later on? Can you add a TODO comment?

@openshift-ci openshift-ci bot added the lgtm label Jun 12, 2024
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov
Copy link
Member Author

kurlov commented Jun 12, 2024

/retest

@openshift-ci openshift-ci bot removed the lgtm label Jun 12, 2024
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

New changes are detected. LGTM label has been removed.

@kurlov kurlov merged commit 712ec5f into main Jun 12, 2024
6 checks passed
@kurlov kurlov deleted the akurlov/ROX-23260-email-service-rate-limiter branch June 12, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants