Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24158: remove unnecessary field from tenant default network policy #1866

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

vladbologa
Copy link
Contributor

@vladbologa vladbologa commented Jun 5, 2024

Description

The empty ingress: [] field is not needed, and Kubernetes does not store in the cluster, after the manifest is applied.

When the network policies are re-applied, the difference in spec is possibly triggering a reconcile, and might be the cause of the network policy violations that we have in ACS CS during probe provisioning.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@openshift-ci openshift-ci bot added the approved label Jun 5, 2024
@vladbologa vladbologa requested a review from ebensh June 5, 2024 18:16
@vladbologa vladbologa changed the title ROX-24158: remove unnecessary field from network policy ROX-24158: remove unnecessary field from default network policy Jun 5, 2024
@vladbologa vladbologa changed the title ROX-24158: remove unnecessary field from default network policy ROX-24158: remove unnecessary field from tenant default network policy Jun 5, 2024
Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcaravel, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vladbologa vladbologa merged commit 5ae1f22 into main Jun 5, 2024
6 checks passed
@vladbologa vladbologa deleted the vb/network-policy-violations branch June 5, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants