-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-23255: emailsender read auth cfg from kubernetes #1860
ROX-23255: emailsender read auth cfg from kubernetes #1860
Conversation
|
||
// TLSWithAdditionalCAs returns a tls config with addiotional trusted ca certificates. | ||
// It uses the systems default certificates and appends the CA certificates in the given files. | ||
func TLSWithAdditionalCAs(caFiles ...string) (*tls.Config, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks great 🎉 |
New changes are detected. LGTM label has been removed. |
98f3fb5
into
jmalsam/ROX-23255-emailsender-auth
* add authentication for ocm for dev and test purposes * add authentication for kubernetes service accounts * prepare getting sub from auth context for rate limitting * add authorization based on issuer, audience, subject and org id * emailsender read auth cfg from kubernetes (#1860)
Description
Follow Up on #1826 .
This adds a function to the AuthConfig of emailsender that allows reading it from it's own Kubernetes service account.
emailsender is expected to be called by central with it's Kubernetes service account. Since emailsender has its own service account as well we can use that information to read the configuration values required for authentication (issuer, audience, jwks_url).
This way we don't need a config file / config map that is different per environment we deploy to, where we have to manually managed the input vars (e.g addon parameters).
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual