Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax annotation to Dockerfile #1838

Merged
merged 1 commit into from
May 28, 2024
Merged

Add syntax annotation to Dockerfile #1838

merged 1 commit into from
May 28, 2024

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented May 28, 2024

Description

This small change magically makes BuildKit cache mounts work properly on microshift.

Reference: docker/buildx#1283 (comment)

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

Copy link
Contributor

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit 2816a10 into main May 28, 2024
6 checks passed
@kovayur kovayur deleted the yury/dockerfile-syntax branch May 28, 2024 13:58
vladbologa added a commit that referenced this pull request May 28, 2024
vladbologa added a commit that referenced this pull request May 28, 2024
Revert "Add syntax annotation to Dockerfile (#1838)"

This reverts commit 2816a10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants