Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-23709: Fix private/admin api matching from regex to string #1828

Merged
merged 4 commits into from
May 27, 2024

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented May 27, 2024

Description

Change the suffix from the regex pattern to string.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur kovayur requested a review from ludydoo May 27, 2024 10:07
@kovayur kovayur changed the title ROX-23709: Fix admin api ROX-23709: Fix admin api matching from regex to string May 27, 2024
@kovayur kovayur changed the title ROX-23709: Fix admin api matching from regex to string ROX-23709: Fix private/admin api matching from regex to string May 27, 2024
Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label May 27, 2024
Copy link
Contributor

openshift-ci bot commented May 27, 2024

New changes are detected. LGTM label has been removed.

@kovayur
Copy link
Contributor Author

kovayur commented May 27, 2024

/retest

@kovayur
Copy link
Contributor Author

kovayur commented May 27, 2024

/override ci/prow/e2e

Copy link
Contributor

openshift-ci bot commented May 27, 2024

@kovayur: Overrode contexts on behalf of kovayur: ci/prow/e2e

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kovayur
Copy link
Contributor Author

kovayur commented May 27, 2024

E2E test job is stuck, overriding

@kovayur kovayur merged commit bddd0b8 into main May 27, 2024
6 checks passed
@kovayur kovayur deleted the yury/fix-admin-api branch May 27, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants