Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-23254: Add AWS SES client V2 #1822

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented May 22, 2024

Description

Add AWS SES V2 golang client to Email service

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

N/A

@kurlov kurlov requested a review from johannes94 May 22, 2024 15:58

// NewSES creates a new SES instance with initialised AWS SES client using AWS Config
func NewSES(ctx context.Context) (*SES, error) {
cfg, err := config.LoadDefaultConfig(ctx)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the recommended way to get session in aws-sdk-go-v2
Migrating from NewSession with aws.Config options

Copy link
Contributor

@johannes94 johannes94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'd love to have an integration test with actual AWS SES here, but we could also instead go for an e2e test once we have the full service ready, so I'll approve.

Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov kurlov merged commit eb20594 into main May 23, 2024
6 checks passed
@kurlov kurlov deleted the akurlov/ROX-23254-add-ses-send-email branch May 23, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants