-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-24273: garbage collection for tenant-resources chart #1819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very useful, I think it will also fix ROX-13199, right?
Yes it would fix it for the tenant-resources chart, not the operator charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ludydoo, vladbologa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Checklist (Definition of Done)
Unit and integration tests addedAdded test description underTest manual
Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Add secret to app-interface Vault or Secrets Manager if necessaryRDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resources(If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environmentTest manual