Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24273: garbage collection for tenant-resources chart #1819

Merged
merged 6 commits into from
May 23, 2024

Conversation

ludydoo
Copy link
Collaborator

@ludydoo ludydoo commented May 21, 2024

Description

  • Add garbage collection for tenant-resources helm chart (on update / delete)
  • Add script to generate resource GVKs managed by the tenant-resources helm chart

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

Sorry, something went wrong.

@ludydoo ludydoo requested a review from a team May 21, 2024 09:56
Copy link
Contributor

@vladbologa vladbologa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very useful, I think it will also fix ROX-13199, right?

fleetshard/pkg/central/reconciler/gen/main.go Outdated Show resolved Hide resolved
@ludydoo ludydoo requested a review from vladbologa May 22, 2024 07:23
@ludydoo
Copy link
Collaborator Author

ludydoo commented May 22, 2024

This is very useful, I think it will also fix ROX-13199, right?

Yes it would fix it for the tenant-resources chart, not the operator charts

fleetshard/pkg/central/reconciler/gen/main.go Outdated Show resolved Hide resolved
fleetshard/pkg/central/reconciler/gen/main.go Outdated Show resolved Hide resolved
fleetshard/pkg/central/reconciler/gen/main.go Outdated Show resolved Hide resolved
fleetshard/pkg/central/reconciler/gen/main.go Outdated Show resolved Hide resolved
@ludydoo ludydoo requested a review from vladbologa May 22, 2024 13:58
@ludydoo ludydoo requested a review from vladbologa May 23, 2024 07:35
Copy link
Contributor

@vladbologa vladbologa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@openshift-ci openshift-ci bot added the lgtm label May 23, 2024
Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ludydoo, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ludydoo ludydoo merged commit eeee761 into main May 23, 2024
6 checks passed
@ludydoo ludydoo deleted the ROX-24273-garbage-collection branch May 23, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants