Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-23254: Email Sender add API package #1815

Merged
merged 6 commits into from
May 23, 2024

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented May 17, 2024

Description

  • handlers should contain parsing request and generating response logic.
  • middleware contains common wrappers for endpoint handlers
  • routes contains path to handler mapping

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

CLUSTER_ID=test go run emailsender/cmd/app/main.go

Copy link
Contributor

openshift-ci bot commented May 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kurlov kurlov changed the title Change structure ROX-23254: Email Sender add API package May 21, 2024
@kurlov kurlov marked this pull request as ready for review May 21, 2024 08:46
@kurlov kurlov requested a review from johannes94 May 21, 2024 08:55
emailsender/pkg/api/handlers.go Outdated Show resolved Hide resolved
)

// LogRequest logs HTTP request
func LogRequest(next http.Handler) http.Handler {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider reusing? If so why does it not fit?

func RequestLoggingMiddleware(handler http.Handler) http.Handler {

@kurlov kurlov requested a review from johannes94 May 23, 2024 12:54
@openshift-ci openshift-ci bot added the lgtm label May 23, 2024
Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov kurlov merged commit 3f29cdf into main May 23, 2024
6 checks passed
@kurlov kurlov deleted the akurlov/ROX-23254-change-structure-emailsender branch May 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants