-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-23254: Email Sender add API package #1815
Conversation
Skipping CI for Draft Pull Request. |
emailsender/pkg/api/middleware.go
Outdated
) | ||
|
||
// LogRequest logs HTTP request | ||
func LogRequest(next http.Handler) http.Handler { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider reusing? If so why does it not fit?
func RequestLoggingMiddleware(handler http.Handler) http.Handler { |
Co-authored-by: Johannes Malsam <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
handlers
should contain parsing request and generating response logic.middleware
contains common wrappers for endpoint handlersroutes
contains path to handler mappingChecklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual