Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24127: tenant resources via gitops #1803

Merged
merged 10 commits into from
May 15, 2024
Merged

Conversation

ludydoo
Copy link
Collaborator

@ludydoo ludydoo commented May 8, 2024

Description

Currently, only tweaking central CRs via gitops is possible.
I want to enable the VPA only for select tenants. But the VPA will be defined in the "tenant-resources" helm chart.

This PR adds the following features

  • Defining the default tenant-resources chart values within the gitops config
  • Overriding per-tenant tenant-resources chart values with gitops config
  • "Graceful" fallback to previous implementation if the values are not provided via the gitops config

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

internal/dinosaur/pkg/gitops/config.go Show resolved Hide resolved
internal/dinosaur/pkg/gitops/config.go Outdated Show resolved Hide resolved
internal/dinosaur/pkg/gitops/service.go Outdated Show resolved Hide resolved
@ludydoo ludydoo requested a review from johannes94 May 13, 2024 15:37
Copy link
Contributor

@johannes94 johannes94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ludydoo ludydoo merged commit 3e40568 into main May 15, 2024
6 checks passed
@ludydoo ludydoo deleted the ROX-24127-tenant-resources-gitops branch May 15, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants