Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-21702: fix error matching logic for central-tls secret not found #1800

Merged
merged 1 commit into from
May 13, 2024

Conversation

johannes94
Copy link
Contributor

@johannes94 johannes94 commented May 8, 2024

Description

The check on the expected error when central-tls secret was not yet created before routes get created was broken because the error we checked for was no longer returned. Leading to error logs like:

E0111 15:09:47.955154 1 runtime.go:246] Unexpected error occurred rhacs-cmg021tu6lpgt9015g6g/probe-7687b89ff9-kd2jv-4fb9: updating routes: creating reencrypt route for central cmg021tu6lpgt9015g6g: getting central-tls secret for tenant probe-7687b89ff9-kd2jv-4fb9: central-tls secret not found 

I've implemented a solution that should now properly check for this error again:

Checklist (Definition of Done)

  • Unit and integration tests added
  • [ ] Added test description under Test manual -> CI is sufficient
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • [] Add secret to app-interface Vault or Secrets Manager if necessary
  • [ ] RDS changes were e2e tested manually
  • [ ] Check AWS limits are reasonable for changes provisioning new resources
  • [ ] (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur
Copy link
Contributor

kovayur commented May 8, 2024

Thanks for the fix @johannes94

@johannes94 johannes94 merged commit 1a90477 into main May 13, 2024
7 checks passed
@johannes94 johannes94 deleted the jmalsam/ROX-21702-stop-logging-central-tls-error branch May 13, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants