ROX-21702: fix error matching logic for central-tls secret not found #1800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The check on the expected error when central-tls secret was not yet created before routes get created was broken because the error we checked for was no longer returned. Leading to error logs like:
I've implemented a solution that should now properly check for this error again:
Checklist (Definition of Done)
[ ] Added test description under-> CI is sufficientTest manual
ROX-12345: ...
[] Add secret to app-interface Vault or Secrets Manager if necessary[ ] RDS changes were e2e tested manually[ ] Check AWS limits are reasonable for changes provisioning new resources[ ] (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environmentTest manual
TODO: Add manual testing efforts