Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24166: Remove kube-rbac-proxy sidecar #1794

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

vladbologa
Copy link
Contributor

@vladbologa vladbologa commented May 7, 2024

Description

The ose-kube-rbac-proxy sidecar is no longer used by the ACS operator (as of 4.4.0, see stackrox/stackrox#9808), so ACS CS should also no longer deploy it.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

Copy link
Collaborator

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine if you just want to remove the proxy.

If you'd like to be able to scrape metrics (and @ebensh sounded like you might want to) you'll most likely also need this bit.

Of course you don't need to do it in this PR just yet.

Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: porridge, rukletsov, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [porridge,vladbologa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vladbologa vladbologa force-pushed the vb/kube-rbac-proxy branch from 8de8f8c to 6beaab1 Compare May 8, 2024 07:07
@openshift-ci openshift-ci bot removed the lgtm label May 8, 2024
Copy link
Contributor

openshift-ci bot commented May 8, 2024

New changes are detected. LGTM label has been removed.

@vladbologa
Copy link
Contributor Author

This is fine if you just want to remove the proxy.

If you'd like to be able to scrape metrics (and @ebensh sounded like you might want to) you'll most likely also need this bit.

Of course you don't need to do it in this PR just yet.

I brought in those changes, thanks!

@vladbologa vladbologa merged commit 715690a into main May 8, 2024
7 checks passed
@vladbologa vladbologa deleted the vb/kube-rbac-proxy branch May 8, 2024 08:06
@vladbologa vladbologa changed the title ROX-22289: Remove kube-rbac-proxy sidecar ROX-22289, ROX-24166: Remove kube-rbac-proxy sidecar May 13, 2024
@vladbologa vladbologa changed the title ROX-22289, ROX-24166: Remove kube-rbac-proxy sidecar ROX-22289,ROX-24166: Remove kube-rbac-proxy sidecar May 13, 2024
@vladbologa vladbologa changed the title ROX-22289,ROX-24166: Remove kube-rbac-proxy sidecar ROX-24166: Remove kube-rbac-proxy sidecar May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants