Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-23252: add email sender to build and push #1784

Merged

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented May 6, 2024

Description

Add email sender service to build and push on app-interface

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

N/A

@openshift-ci openshift-ci bot added the approved label May 6, 2024
@kurlov kurlov requested review from kovayur and johannes94 May 6, 2024 06:25
Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johannes94 johannes94 merged commit 8d1f1dc into main May 6, 2024
3 checks passed
@johannes94 johannes94 deleted the akurlov/ROX-23252-add-email-sender-to-build-and-push branch May 6, 2024 06:30
johannes94 added a commit that referenced this pull request May 6, 2024
@johannes94 johannes94 restored the akurlov/ROX-23252-add-email-sender-to-build-and-push branch May 6, 2024 09:45
ebensh pushed a commit that referenced this pull request May 6, 2024
Revert "ROX-23252: add email sender to build and push (#1784)"

This reverts commit 8d1f1dc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants