Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-23550: Change DNS from kube-dns to openshift-dns #1781

Merged
merged 2 commits into from
May 3, 2024

Conversation

ebensh
Copy link
Collaborator

@ebensh ebensh commented May 3, 2024

No description provided.

@ebensh ebensh force-pushed the evan/rox-23550-fix-openshift-dns branch from 7bd82ca to 9d542ac Compare May 3, 2024 13:04
@ebensh ebensh temporarily deployed to development May 3, 2024 13:04 — with GitHub Actions Inactive
- to:
- namespaceSelector:
matchLabels:
kubernetes.io/metadata.name: openshift-dns
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for ports?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary, though we can apply it. I was having trouble figuring out whether openshift DNS is running on port 53 or 5353 - the service runs on 53, but I see connections in debug also accessing 5353, and it's unclear to me when the NetworkPolicy applies. We could also just do both (like I had in my first commit).

I'll add back both - please take another look.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. oc -n openshift-dns describe pod/dns-default-8pbsf

Containers:
dns:
Container ID: cri-o://87736ba19b94b7273825bfcb17d0f2c333d5daec8c0d9287c8bd19051b1f288f
Image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:b51ade173e06e83d256f5f4467855f2763140f39fe0ef1bc93540436cc540e81
Image ID: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:b51ade173e06e83d256f5f4467855f2763140f39fe0ef1bc93540436cc540e81
Ports: 5353/UDP, 5353/TCP

So the application's listening on 5353, but the service itself is on 53:

oc get services -n openshift-dns
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
dns-default ClusterIP 172.30.0.10 53/UDP,53/TCP,9154/TCP 283d

I think it will use the pod's listening port, not the service's port

@ebensh ebensh temporarily deployed to development May 3, 2024 13:37 — with GitHub Actions Inactive
@ebensh ebensh requested a review from ludydoo May 3, 2024 13:39
Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebensh ebensh merged commit 6f552bb into main May 3, 2024
6 of 7 checks passed
@ebensh ebensh deleted the evan/rox-23550-fix-openshift-dns branch May 3, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants