-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-23550: Change DNS from kube-dns to openshift-dns #1781
Conversation
7bd82ca
to
9d542ac
Compare
- to: | ||
- namespaceSelector: | ||
matchLabels: | ||
kubernetes.io/metadata.name: openshift-dns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for ports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary, though we can apply it. I was having trouble figuring out whether openshift DNS is running on port 53 or 5353 - the service runs on 53, but I see connections in debug also accessing 5353, and it's unclear to me when the NetworkPolicy applies. We could also just do both (like I had in my first commit).
I'll add back both - please take another look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. oc -n openshift-dns describe pod/dns-default-8pbsf
Containers:
dns:
Container ID: cri-o://87736ba19b94b7273825bfcb17d0f2c333d5daec8c0d9287c8bd19051b1f288f
Image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:b51ade173e06e83d256f5f4467855f2763140f39fe0ef1bc93540436cc540e81
Image ID: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:b51ade173e06e83d256f5f4467855f2763140f39fe0ef1bc93540436cc540e81
Ports: 5353/UDP, 5353/TCP
So the application's listening on 5353, but the service itself is on 53:
oc get services -n openshift-dns
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
dns-default ClusterIP 172.30.0.10 53/UDP,53/TCP,9154/TCP 283d
I think it will use the pod's listening port, not the service's port
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebensh, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.