-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-23984: install vpa operator #1780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though a couple questions:
- Should we just install the operator as a normal openshift operator (via OCM) as part of our cluster turn-up, treating it like any other OpenShift provided service/dependency? If there's no configuration going on, why is it necessary to install via the Helm chart? And if we do want to install it via the Helm chart, can we document why in the PR description or a README.md, so we know why it's here?
Other than that the configuration looks reasonable to me
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebensh, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -0,0 +1,23 @@ | |||
# Patterns to ignore when building packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these files really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, it was there for every chart, didn't want to break the convention
Description
Installing the VPA operator.
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TODO: Add manual testing efforts