Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-23984: install vpa operator #1780

Merged
merged 7 commits into from
May 7, 2024
Merged

Conversation

ludydoo
Copy link
Collaborator

@ludydoo ludydoo commented May 2, 2024

Description

Installing the VPA operator.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@openshift-ci openshift-ci bot added the approved label May 2, 2024
@ludydoo ludydoo removed the request for review from GrimmiMeloni May 2, 2024 19:54
Copy link
Collaborator

@ebensh ebensh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though a couple questions:

  1. Should we just install the operator as a normal openshift operator (via OCM) as part of our cluster turn-up, treating it like any other OpenShift provided service/dependency? If there's no configuration going on, why is it necessary to install via the Helm chart? And if we do want to install it via the Helm chart, can we document why in the PR description or a README.md, so we know why it's here?

Other than that the configuration looks reasonable to me

Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -0,0 +1,23 @@
# Patterns to ignore when building packages.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these files really necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, it was there for every chart, didn't want to break the convention

@ludydoo ludydoo merged commit 40bd4e3 into main May 7, 2024
6 checks passed
@ludydoo ludydoo deleted the ROX-23984-install-vpa-operator branch May 7, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants