-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-23550: Add NetworkPolicy to Tenant Helm chart #1767
Conversation
Skipping CI for Draft Pull Request. |
18e13c3
to
57d1638
Compare
57d1638
to
d0a3e29
Compare
d0a3e29
to
a747436
Compare
a747436
to
de84746
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you ever find out if we can disable network policy creation in the operator? Also, do we need scanner v4 network policies, too?
I'll try to applly these network policies later today and see if I can test them out.
fleetshard/pkg/central/charts/data/tenant-resources/templates/network-policy.yaml
Outdated
Show resolved
Hide resolved
fleetshard/pkg/central/charts/data/tenant-resources/templates/network-policy.yaml
Outdated
Show resolved
Hide resolved
fleetshard/pkg/central/charts/data/tenant-resources/templates/network-policy.yaml
Outdated
Show resolved
Hide resolved
fleetshard/pkg/central/charts/data/tenant-resources/templates/network-policy.yaml
Outdated
Show resolved
Hide resolved
de84746
to
6a86fa7
Compare
6a86fa7
to
1287f6d
Compare
1287f6d
to
8e76deb
Compare
8e76deb
to
f06e759
Compare
f06e759
to
548d49e
Compare
548d49e
to
a0df19b
Compare
…NetworkPolicies and EgressFirewalls are generated.
…etwork policies are written
…t network in fleetshard sync
…ange for later use
…ts from scanner to central.
623597f
to
0678aae
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebensh, kovayur, vladbologa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add NetworkPolicy's to the Fleetshard Sync Tenant Helm chart. Their creation is guarded by the new secureTenantNetwork configuration option.
These policies effectively replace and improve the ACS Operator's default NetworkPolicy's.
Where possible, I have tried to optimize per https://docs.openshift.com/container-platform/4.14/networking/network_policy/about-network-policy.html#nw-networkpolicy-optimize-ovn_about-network-policy
Document discussing the changes: https://docs.google.com/document/d/15-rlsU_wDsv6TX_2hKHNFir82W1T9Ov1SOnRSha1VUY/edit
Checklist (Definition of Done)
Test manual
Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Add secret to app-interface Vault or Secrets Manager if necessaryRDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resourcesTest manual
TODO: Add manual testing efforts