Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-16615: run probe cleanup after all specs have been completed #1757

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Apr 10, 2024

Description

Problem

We create Central for every region in a different goroutine. After the execution, the cleanup is called. The cleanup deletes all centrals created by probe, not only the one that created in this goroutine. As a result, central that is beeing provisioned in parallel gets deleted.

Solution

This change moves the cleanup function into place after all central creations have been completed.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov, porridge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kovayur,kurlov,porridge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur
Copy link
Contributor Author

kovayur commented Apr 10, 2024

/override ci/prow/e2e

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

@kovayur: Overrode contexts on behalf of kovayur: ci/prow/e2e

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kovayur kovayur merged commit 800673c into main Apr 10, 2024
8 checks passed
@kovayur kovayur deleted the yury/probe-global-cleanup branch April 10, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants