ROX-23370: add requests and limits to FM initContainer #1747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds requests and limits to the initContainer of fleet-manager.
The initContainer executes
fleet-manager migrate
, which is why I decided to re-use the same requests and limits that we use for thefleet-manager
container itself (which executesfleet-manager serve
).It's not possible to see on Prometheus the actual memory & CPU usage of the init container in production, probably because the process is too short lived and it's not getting scraped. To get an estimation of its usage, I ran this locally:
The maximum resident set was ~70MiB. This should work well with the current memory requests / limits of 512Mi / 1024Mi.
I also looked at the CPU usage, which peaked at 80%. This should also work well with the current CPU requests / limits of 200m / 1.
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TODO: Add manual testing efforts