Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-22428: Rename dinosaurService#Update #1721

Merged
merged 1 commit into from
Mar 22, 2024
Merged

ROX-22428: Rename dinosaurService#Update #1721

merged 1 commit into from
Mar 22, 2024

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Mar 20, 2024

Description

Rename dinosaurService Update to UpdateIgnoreNils to better highlight that it doesn't support nil values update.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

CI

@kovayur kovayur requested a review from parametalol March 20, 2024 13:48
@kovayur kovayur force-pushed the yury/rename-method branch from 492c6a9 to ff23de5 Compare March 20, 2024 13:52
@parametalol
Copy link
Contributor

See also #1720.

parametalol
parametalol approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@parametalol parametalol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although not elegant, but may help.

@openshift-ci openshift-ci bot added the lgtm label Mar 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0x656b694d, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit 8af7a18 into main Mar 22, 2024
8 checks passed
@kovayur kovayur deleted the yury/rename-method branch March 22, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parametalol parametalol parametalol approved these changes

Assignees

@parametalol parametalol

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kovayur @parametalol