Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-16615: Make the probe service create multiple centrals (per region / cloud provider) #1719

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Mar 18, 2024

Description

Make the probe service create multiple central specs (different cloud providers/regions) in a single probe run.
The change is a prerequisite for migrating the probe service from the data plane to the control plane.
The change is backward compatible w.r.t. the helm chart => no deployment changes needed.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

Test probe:

export FLEET_MANAGER_ENDPOINT=<stage url>
export AUTH_TYPE=OCM
export OCM_USERNAME=<ocm username>
export OCM_TOKEN=token
export CENTRAL_SPECS=`[{ "cloudProvider": "aws", "region": "us-east-1" }, { "cloudProvider": "aws", "region": "eu-west-1" }]`
./probe/bin/probe start

Test helm chart

export HELM_DRY_RUN=true
export HELM_DEBUG=true
./deploy/helm/probe/deploy.sh dev acs-dev-dp-01

@kovayur kovayur requested review from kurlov and stehessel March 18, 2024 14:08
@kovayur kovayur changed the title ROX-16615: Make probe multiregion ROX-16615: Make the probe service create multiple centrals (per region / cloud provider) Mar 18, 2024
@kovayur kovayur force-pushed the yury/probe-multiregion branch from 404219e to 3a431bd Compare March 18, 2024 14:22
probe/pkg/metrics/metrics.go Outdated Show resolved Hide resolved
probe/pkg/metrics/server.go Outdated Show resolved Hide resolved
probe/pkg/metrics/server.go Outdated Show resolved Hide resolved
Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit c2f6dfe into main Mar 19, 2024
8 checks passed
@kovayur kovayur deleted the yury/probe-multiregion branch March 19, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants