-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-16615: Make the probe service create multiple centrals (per region / cloud provider) #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovayur
changed the title
ROX-16615: Make probe multiregion
ROX-16615: Make the probe service create multiple centrals (per region / cloud provider)
Mar 18, 2024
kovayur
force-pushed
the
yury/probe-multiregion
branch
from
March 18, 2024 14:22
404219e
to
3a431bd
Compare
stehessel
approved these changes
Mar 19, 2024
kovayur
force-pushed
the
yury/probe-multiregion
branch
from
March 19, 2024 08:42
949c5b5
to
c9c9ba5
Compare
kurlov
approved these changes
Mar 19, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, kurlov, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the probe service create multiple central specs (different cloud providers/regions) in a single probe run.
The change is a prerequisite for migrating the probe service from the data plane to the control plane.
The change is backward compatible w.r.t. the helm chart => no deployment changes needed.
Checklist (Definition of Done)
Test manual
Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Test manual
Test probe:
Test helm chart