Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-22593: git hook fix #1696

Merged
merged 1 commit into from
Mar 12, 2024
Merged

ROX-22593: git hook fix #1696

merged 1 commit into from
Mar 12, 2024

Conversation

ludydoo
Copy link
Collaborator

@ludydoo ludydoo commented Mar 11, 2024

Description

On local dev environments, the git hook would fail because there is a go.mod without any go files (there was a file, but with a build tag which gets ignored). Added a noop go file

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur
Copy link
Contributor

kovayur commented Mar 11, 2024

Hey @ludydoo could you please elaborate on the problem? I haven't faced this problem before.

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, ludydoo, mclasmeier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johannes94,ludydoo,mclasmeier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ludydoo
Copy link
Collaborator Author

ludydoo commented Mar 12, 2024

Hey @ludydoo could you please elaborate on the problem? I haven't faced this problem before.

Some people are experiencing a precommit git hook failure. I know of @0x656b694d and I. For example, if there's a go.mod file in a directory, but there's no *.go file, or the .go files have a build tag, then the precommit hook fails.

@ludydoo ludydoo merged commit 7f66fcc into main Mar 12, 2024
8 checks passed
@ludydoo ludydoo deleted the ROX-22593-git-hook-fix branch March 12, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants