ROX-22360: expired_at is not nullified

[parametalol]

Description

The bug is caused by using the DinosaurService.Update method instead of DinosaurService.Updates. The difference is in handling NULL values, apparently.

• Commit 669ac9e with the fix: use Updates instead of Update
• Commit 5d3e4a4 with refactoring

Checklist (Definition of Done)

• Unit and integration tests added
• Added test description under Test manual
• Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
• CI and all relevant tests are passing
• Add the ticket number to the PR title if available, i.e. ROX-12345: ...
• Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
• Add secret to app-interface Vault or Secrets Manager if necessary
• RDS changes were e2e tested manually
• Check AWS limits are reasonable for changes provisioning new resources

Test manual

Tested with patching via centrals/{id}/expired-at and restarting the pod to trigger expiration manager, which nullifies the field.

[stehessel]

Can you explain what caused the bug and what the fix is? It would also be good to have a test in the e2e test suite that would catch such issues.

[parametalol]

Can you explain what caused the bug and what the fix is? It would also be good to have a test in the e2e test suite that would catch such issues.

Updated description. The e2e comes with #1644.

[stehessel]

The bug is caused by using the DinosaurService.Update method instead of DinosaurService.Updates. The difference is in handling NULL values, apparently.

Could you please add a warning as a comment to DinosaurService.Update clarifying that NULL values are ignored?

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 0x656b694d, stehessel
Once this PR has been reviewed and has the lgtm label, please assign simonbaeumer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment