refactor: allow for clean-up and regenerating go files

[parametalol]

• Resolve circular dependencies of mocks and interfaces.
• New clean/go-generated Makefile target.
• New CI test for generated code.

Tested:

$ make clean/go-generated
Cleaning generated .go files...
./fleetshard/pkg/central/cloudprovider/dbclient_moq.go
./fleetshard/pkg/cipher/cipher_moq.go
./internal/dinosaur/pkg/clusters/clusterbuilder_moq.go
./internal/dinosaur/pkg/clusters/provider_moq.go
./internal/dinosaur/pkg/clusters/provider_factory_moq.go
./internal/dinosaur/pkg/services/cloud_providers_moq.go
./internal/dinosaur/pkg/services/cluster_placement_strategy_moq.go
./internal/dinosaur/pkg/services/clusterservice_moq.go
./internal/dinosaur/pkg/services/dinosaurservice_moq.go
./internal/dinosaur/pkg/services/observatorium_service_moq.go
./internal/dinosaur/pkg/services/quotaservice_moq.go
./internal/dinosaur/pkg/services/quota_service_factory_moq.go
./internal/dinosaur/pkg/services/telemetry_moq.go
./pkg/auth/auth_agent_service_moq.go
./pkg/client/aws/client_moq.go
./pkg/client/iam/client_moq.go
./pkg/client/iam/gocloak_moq.go
./pkg/client/observatorium/mocks/api_moq.go
./pkg/client/ocm/mocks/client_moq.go
./pkg/client/ocm/mocks/id_generator_moq.go
./pkg/client/fleetmanager/mocks/client_moq.go
./pkg/client/telemetry/telemeter_moq.go
./pkg/client/telemetry/config_moq.go
./pkg/services/authorization/authorization_moq.go
./pkg/services/sso/iam_service_moq.go
./pkg/workers/worker_interface_moq.go
./probe/pkg/probe/probe_moq.go
$ make generate
rm -rf internal/dinosaur/pkg/api/public
/home/mipetrov/go/src/github.com/stackrox/acs-fleet-manager/bin/openapi-generator validate -i openapi/fleet-manager.yaml
Validating spec (openapi/fleet-manager.yaml)
.
.
.
gofmt -w pkg/client/redhatsso/api
go generate ./...
$ echo $?
0

[parametalol]

Current dependencies on/for this PR:

• main
  • PR refactor: allow for clean-up and regenerating go files #1620 👈

[janisz]

There is

• chore: Test that go mod tidy is a no-op in PR CI run #1622

[janisz]

Related to although in that one we only check for mocks

• fix(ci): check if mocks were deleted with sources stackrox#9153

[janisz]

since there is just one occurence of fleetmanager in this file I think we can swap this imports.

Suggested change

	"github.com/stackrox/acs-fleet-manager/pkg/client/fleetmanager"
	fmImpl "github.com/stackrox/acs-fleet-manager/pkg/client/fleetmanager/impl"
	fm "github.com/stackrox/acs-fleet-manager/pkg/client/fleetmanager"
	fleetmanager "github.com/stackrox/acs-fleet-manager/pkg/client/fleetmanager/impl"

[janisz]

If we replace interface idGenerator ocm.IDGenerator we can remove this import and keep other namped as ocm causing less changes

[janisz]

this should be a separated PR with enabling unused linter

[parametalol]

#1623

[janisz]

If we work with naming then we can keep diff smaller on the other hand it's good to have it consistent. I'd like to remove changes not related to this PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 0x656b694d, janisz
Once this PR has been reviewed and has the lgtm label, please assign ludydoo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[parametalol]

/retest