Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-21946: FS set central-tls OwnerReference if not already set #1619

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

johannes94
Copy link
Contributor

@johannes94 johannes94 commented Jan 25, 2024

Description

After restore of central-tls secret the owner reference is not set to the central CR again. This blocks the operator from automatically rotating leaf certificates for central, since it won't touch secrets not owned by it.

With this PR fleetshard-sync, will set the owner reference of the secret to the CR it creates, which should fix the issue.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

CI and added e2e tests should be sufficient

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@johannes94 johannes94 changed the title ROX-21946: FS set central tls ownerreference if not already set ROX-21946: FS set central-tls OwnerReference if not already set Jan 25, 2024
@johannes94 johannes94 requested review from a team and stehessel January 25, 2024 15:02
@johannes94 johannes94 force-pushed the jmalsam/ROX-21946-set-central-tls-ownerreference branch from 35283a8 to f568fa1 Compare February 5, 2024 19:03
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johannes94 johannes94 merged commit e46f7ca into main Feb 6, 2024
9 checks passed
@johannes94 johannes94 deleted the jmalsam/ROX-21946-set-central-tls-ownerreference branch February 6, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants