-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-21946: FS set central-tls OwnerReference if not already set #1619
Merged
johannes94
merged 6 commits into
main
from
jmalsam/ROX-21946-set-central-tls-ownerreference
Feb 6, 2024
Merged
ROX-21946: FS set central-tls OwnerReference if not already set #1619
johannes94
merged 6 commits into
main
from
jmalsam/ROX-21946-set-central-tls-ownerreference
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes94
temporarily deployed
to
development
January 25, 2024 09:26 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
January 25, 2024 09:26 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
January 25, 2024 09:26 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
January 25, 2024 11:01 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
January 25, 2024 11:01 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
January 25, 2024 11:01 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
January 25, 2024 12:37 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
January 25, 2024 12:37 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
January 25, 2024 12:37 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
January 25, 2024 13:26 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
January 25, 2024 13:26 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
January 25, 2024 13:26 — with
GitHub Actions
Inactive
johannes94
changed the title
ROX-21946: FS set central tls ownerreference if not already set
ROX-21946: FS set central-tls OwnerReference if not already set
Jan 25, 2024
stehessel
reviewed
Jan 29, 2024
stehessel
reviewed
Jan 29, 2024
stehessel
reviewed
Jan 29, 2024
johannes94
force-pushed
the
jmalsam/ROX-21946-set-central-tls-ownerreference
branch
from
February 5, 2024 19:03
35283a8
to
f568fa1
Compare
johannes94
temporarily deployed
to
development
February 5, 2024 19:03 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
February 5, 2024 19:03 — with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
February 5, 2024 19:03 — with
GitHub Actions
Inactive
stehessel
approved these changes
Feb 6, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
johannes94
deleted the
jmalsam/ROX-21946-set-central-tls-ownerreference
branch
February 6, 2024 07:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After restore of central-tls secret the owner reference is not set to the central CR again. This blocks the operator from automatically rotating leaf certificates for central, since it won't touch secrets not owned by it.
With this PR fleetshard-sync, will set the owner reference of the secret to the CR it creates, which should fix the issue.
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
CI and added e2e tests should be sufficient