ROX-21695: Increase collector memory usage for CO-RE BPF collection method #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtodor
requested review from
ebensh,
kovayur,
johannes94 and
GrimmiMeloni
as code owners
mtodor
requested review from
kurlov and
johannes94
and removed request for
johannes94,
ebensh and
kovayur
johannes94
approved these changes
Jan 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, mtodor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The collector has a slightly larger memory footprint with the CO-RE BPF collection method. Since we have recently switched to this collection method on our ACSCS-secured clusters, we should adjust memory requirements for that.
This PR increases memory from 140Mi to 200Mi - more info can be found in the related JIRA ticket.
Checklist (Definition of Done)
[ ] Unit and integration tests added[ ] Added test description underTest manual[ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)[ ] CI and all relevant tests are passingROX-12345: ...[ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.[ ] Add secret to app-interface Vault or Secrets Manager if necessary[ ] RDS changes were e2e tested manually[ ] Check AWS limits are reasonable for changes provisioning new resourcesTest manual
I didn't do any manual testing.
But, after PR is merged, I'll check the status of the integration cluster because an update should be applied to it after changes are merged to the main.