-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-21779 Add envoy active listener #1602
Conversation
filter_chains: | ||
- filter_chain_match: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole filter chain was an attempt at using sni-based certificate selection, which doesn't work with openshift ingress
@@ -859,87 +859,15 @@ objects: | |||
address: 0.0.0.0 | |||
port_value: 9001 | |||
listener_filters: | |||
- name: tls_inspector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TLS inspector was also added to perform SNI-based routing. No longer needed
- transport_socket: | ||
name: envoy.transport_sockets.tls | ||
typed_config: | ||
"@type": type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.DownstreamTlsContext | ||
full_scan_certs_on_sni_mismatch: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added to try selecting the proper certificate
- certificate_chain: {filename: "/secrets/active-tls/tls.crt"} | ||
private_key: {filename: "/secrets/active-tls/tls.key"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This listener doesn't use this certificate, it was added to try resolving the correct cert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. I'm looking at this envoy config for the first time may be worth to get another review, but IIUC the only difference here is the TLS cert served by the new listener.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Openshift ingress does not forward SNI headers, so envoy is unable to distinguish requests coming from fleet-manager-envoy vs fleet-manager-active services, and unable to resolve the correct certificate.
The solution is to add a separate listener on a different port, to server the fleet-manager-active service and use the correct certificate.