Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-18694: Bump envoy to 1.28.0 version #1550

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented Jan 4, 2024

Description

Bumps Envoy to 1.28.0.
1.16.1 Envoy version is no longer supported
Some Envoy configuration tunes are necessary to be able to run on 1.28

Checklist (Definition of Done)

- [ ] Unit and integration tests added

  • Added test description under Test manual
    - [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
    - [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
    - [ ] Add secret to app-interface Vault or Secrets Manager if necessary
    - [ ] RDS changes were e2e tested manually
    - [ ] Check AWS limits are reasonable for changes provisioning new resources

Test manual

Local validation of the Envoy config:

error initializing configuration '/tmp/d7164643-ed77-4827-9918-6d11cd685ef3/conf.yaml': Invalid path: /secrets/tls/tls.crt

Which is expected because there is no such secret.

If skip TLS secret mount in Envoy then validation works fine:

[info][main] [source/server/server.cc:837] runtime: {}
[info][config] [source/server/configuration_impl.cc:159] loading tracing configuration
[info][config] [source/server/configuration_impl.cc:118] loading 0 static secret(s)
[info][config] [source/server/configuration_impl.cc:124] loading 2 cluster(s)
[info][config] [source/server/configuration_impl.cc:128] loading 2 listener(s)
[info][lua] [source/extensions/filters/http/lua/lua_filter.cc:220] envoy_on_request() function not found. Lua filter will not hook requests.
[info][config] [source/server/configuration_impl.cc:145] loading stats configuration

------------
configuration '/tmp/ca4fa18b-3ac3-44c5-b8a1-0f1c5376d484/conf.yaml' OK

admin:
access_log_path: /dev/null
Copy link
Member Author

@kurlov kurlov Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

access_log_path is deprecated and logs are discarded by default

Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…p_envoy_to_1.28

# Conflicts:
#	.secrets.baseline
#	templates/service-template.yml
@openshift-ci openshift-ci bot removed the lgtm label Jan 16, 2024
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

New changes are detected. LGTM label has been removed.

@kurlov kurlov merged commit a963a17 into main Jan 16, 2024
5 checks passed
@kurlov kurlov deleted the akurlov/ROX-18694_bump_envoy_to_1.28 branch January 16, 2024 11:20
kovayur pushed a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants