-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-18694: Bump envoy to 1.28.0 version #1550
Conversation
admin: | ||
access_log_path: /dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
access_log_path
is deprecated and logs are discarded by default
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kurlov, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…p_envoy_to_1.28 # Conflicts: # .secrets.baseline # templates/service-template.yml
New changes are detected. LGTM label has been removed. |
Description
Bumps Envoy to 1.28.0.
1.16.1 Envoy version is no longer supported
Some Envoy configuration tunes are necessary to be able to run on 1.28
Checklist (Definition of Done)
- [ ] Unit and integration tests addedTest manual
- [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
- [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.- [ ] Add secret to app-interface Vault or Secrets Manager if necessary- [ ] RDS changes were e2e tested manually- [ ] Check AWS limits are reasonable for changes provisioning new resourcesTest manual
Local validation of the Envoy config:
Which is expected because there is no such secret.
If skip TLS secret mount in Envoy then validation works fine: