dogfooding: set collector collection method to CORE_BPF #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes94
requested review from
ebensh,
kovayur and
GrimmiMeloni
as code owners
johannes94
temporarily deployed
to
development
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
GitHub Actions
Inactive
johannes94
requested review from
erthalion,
ludydoo and
rukletsov
and removed request for
GrimmiMeloni and
kovayur
erthalion
approved these changes
Dec 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erthalion, johannes94 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
johannes94
changed the title
johannes94
deleted the
jmalsam/set-collector-core-bpf-for-securedclusters
branch
johannes94
added a commit
that referenced
this pull request
Jan 18, 2024
* set collector collection method to core BPF for dogfooding * update only secured cluster CRD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Collector team asked us to set the collection method for our dogfooding instances to
CORE_BPF.In the same context I updated the CRD that is used for initial secured cluster installation if no CRD in the cluster exists yet to a more recent version (4.3.1) that support the
CORE_BPFvalue forspec.collector.collection.Checklist (Definition of Done)
- [ ] Unit and integration tests added- [ ] Added test description underTest manual- [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)- [ ] Add the ticket number to the PR title if available, i.e.ROX-12345: ...- [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.- [ ] Add secret to app-interface Vault or Secrets Manager if necessary- [ ] RDS changes were e2e tested manually- [ ] Check AWS limits are reasonable for changes provisioning new resourcesTest manual
TODO: Add manual testing efforts